-
Notifications
You must be signed in to change notification settings - Fork 76
Fixe for issue #266, #265 and refactoring #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
|
LGTM to me, thanks for asking me a reviewer!
|
setup.py
Outdated
| 'adal>=0.4.2', | ||
| 'requests>=2.20.0' | ||
| 'requests>=2.20.0', | ||
| 'azure-common~=1.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not required to do that if you don't import "azure.common" (but doesn't harm)
setup.py
Outdated
| extras_require={ | ||
| ":python_version<'3.4'": ['pathlib2'], | ||
| ":python_version<='2.7'": ['futures'], | ||
| ":python_version<'3.0'": ['azure-mgmt-nspkg'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jsut realized I read too fast the first time, should be "azure-nspkg"
This checklist is used to make sure that common guidelines for a pull request are followed.
Description of the change
Fixe for issue #265 and #265. Also some refactoring for multiprocessor acl change code.
General Guidelines
Will be done when merge to master later and making a new release