Skip to content

Conversation

@akharit
Copy link
Member

@akharit akharit commented Jan 3, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Fixe for issue #265 and #265. Also some refactoring for multiprocessor acl change code.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
    Will be done when merge to master later and making a new release
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 86.65% when pulling 62fa2ee on akharit-bugfixes into eb585b4 on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 86.65% when pulling 62fa2ee on akharit-bugfixes into eb585b4 on dev.

@coveralls
Copy link

coveralls commented Jan 3, 2019

Coverage Status

Coverage increased (+0.05%) to 86.65% when pulling c1ca10d on akharit-bugfixes into eb585b4 on dev.

@akharit akharit requested a review from lmazuel January 3, 2019 23:57
@lmazuel
Copy link
Member

lmazuel commented Jan 4, 2019

LGTM to me, thanks for asking me a reviewer!
To double-check everything works:

  • Your sdist must contains azure/__init__.py (with the pkgutil syntax)
  • Your wheel must NOT contain azure/__init__.py
  • Install the wheel on Python 3 must NOT install azure-nspkg

setup.py Outdated
'adal>=0.4.2',
'requests>=2.20.0'
'requests>=2.20.0',
'azure-common~=1.1'
Copy link
Member

@lmazuel lmazuel Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not required to do that if you don't import "azure.common" (but doesn't harm)

setup.py Outdated
extras_require={
":python_version<'3.4'": ['pathlib2'],
":python_version<='2.7'": ['futures'],
":python_version<'3.0'": ['azure-mgmt-nspkg'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jsut realized I read too fast the first time, should be "azure-nspkg"

@akharit akharit merged commit 3e8177e into dev Jan 4, 2019
@akharit akharit deleted the akharit-bugfixes branch March 6, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants