Skip to content

Conversation

@akharit
Copy link
Member

@akharit akharit commented Aug 28, 2018


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Changing the order of distributions parameter. With the previous order i.e sdist first, the whl package created doesn't have azure-nspkg as dependency.

This causes imports to fail for Python 2.7(#236 ) due to different import behavior in Python 2 vs 3.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • [] The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
    NA
  • Links to associated bugs, if any, are in the description.

@akharit akharit requested a review from lmazuel August 28, 2018 22:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.596% when pulling 39be9bd on akharit-travis-check into 380228b on master.

@akharit akharit merged commit eee1a4b into master Aug 29, 2018
@akharit akharit deleted the akharit-travis-check branch September 7, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants