Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve stack trace DocumentClientException to ResponseMessage #921

Merged
merged 10 commits into from
Nov 21, 2019
Merged

Preserve stack trace DocumentClientException to ResponseMessage #921

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cba16e1
DocumentClientException to ResponseMessage now uses ToString() to pre…
Oct 18, 2019
0c9a3d2
Adding unit test
Oct 21, 2019
a4a72fd
Merge remote-tracking branch 'origin/master' into users/jawilley/erro…
Oct 21, 2019
7cca31b
Updated changelog
Oct 21, 2019
ac9231e
Updated test
Oct 22, 2019
cdba729
Merge to latest
Oct 23, 2019
87f8663
Updated linq expected error message
Oct 23, 2019
8b73c8e
Fixed another linq test
Oct 23, 2019
ec0bb45
Merge to latest
Nov 20, 2019
c940358
Fixed bad merge
Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions Microsoft.Azure.Cosmos/src/Util/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ namespace Microsoft.Azure.Cosmos

internal static class Extensions
{
private static readonly char[] NewLineCharacters = new[] { '\r', '\n' };

internal static ResponseMessage ToCosmosResponseMessage(this DocumentServiceResponse response, RequestMessage requestMessage)
{
Debug.Assert(requestMessage != null, nameof(requestMessage));
Expand Down Expand Up @@ -59,24 +57,7 @@ internal static ResponseMessage ToCosmosResponseMessage(this DocumentClientExcep

// if there is a status code then it came from the backend, return error as http error instead of throwing the exception
ResponseMessage cosmosResponse = new ResponseMessage(dce.StatusCode ?? HttpStatusCode.InternalServerError, request);
string reasonPhraseString = string.Empty;
if (!string.IsNullOrEmpty(dce.Message))
{
if (dce.Message.IndexOfAny(Extensions.NewLineCharacters) >= 0)
{
StringBuilder sb = new StringBuilder(dce.Message);
sb = sb.Replace("\r", string.Empty);
sb = sb.Replace("\n", string.Empty);
reasonPhraseString = sb.ToString();
}
else
{
reasonPhraseString = dce.Message;
}
}

cosmosResponse.ErrorMessage = reasonPhraseString;
cosmosResponse.Error = dce.Error;
cosmosResponse.ErrorMessage = dce.ToString();
j82w marked this conversation as resolved.
Show resolved Hide resolved
kirankumarkolli marked this conversation as resolved.
Show resolved Hide resolved

if (dce.Headers != null)
{
Expand Down