Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CreateIfNotExistsAsync to container builder #592

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Adding CreateIfNotExistsAsync to container builder #592

merged 4 commits into from
Jul 24, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jul 24, 2019

Pull Request Template

Description

Adding CreateIfNotExistsAsync to container builder

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

Put closes #591

@j82w j82w added the feature-request New feature or request label Jul 24, 2019
@j82w
Copy link
Contributor Author

j82w commented Jul 24, 2019

@leopasta please take a look

@j82w j82w self-assigned this Jul 24, 2019
@kirankumarkolli kirankumarkolli merged commit a88e516 into master Jul 24, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/container_builder_ifnotexist branch July 24, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@j82w j82w

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CreateIfNotExistAsync(Nullable<Int32>) to ContainerBuilder
2 participants
@j82w @kirankumarkolli