Skip to content

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jul 16, 2019

Pull Request Template

Description

Currently item request options pre/post triggers are internal which prevents users from running triggers on item operations. This was a missed because the properties do exist, but are internal. So all the test have access to the property.

ItemRequestOptions options = new ItemRequestOptions
{
	PreTriggers = new List<string>()
	{
		"preTrigger"
	},

	PostTriggers = new List<string>()
	{
		"postTrigger"
	}
};

Testing

Unit tests already exist:
CosmosClientResourceUnitTests.ValidateItemRequestOptions

Type of change

Please delete options that are not relevant.

  • [x ] New feature (non-breaking change which adds functionality)

Closing issues

Put closes #556

@j82w j82w added the bug Something isn't working label Jul 16, 2019
@j82w j82w requested a review from kirillg as a code owner July 16, 2019 16:15
@j82w j82w self-assigned this Jul 16, 2019
simplynaveen20
simplynaveen20 previously approved these changes Jul 16, 2019
@kirankumarkolli
Copy link
Member

Please add examples and contract changes to issue.

@kirankumarkolli
Copy link
Member

Are there UT covering both of them?

@kirankumarkolli kirankumarkolli added feature-request New feature or request Release-Notes and removed bug Something isn't working labels Jul 16, 2019
@kirankumarkolli
Copy link
Member

ChangeLog update please

@kirankumarkolli kirankumarkolli merged commit d09bbef into master Jul 17, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/item_request_option_triggers branch July 17, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request Release-Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make item request options pre/post trigger public
3 participants