Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client encryption]: Add JsonNodeSqlSerializer #4779

Merged

Conversation

JanHyka
Copy link
Contributor

@JanHyka JanHyka commented Oct 9, 2024

Pull Request Template

Description

Initial commit for JsonNode on Encryption path. This is currently not executed on any production/preview path. Depends on JsonNode features available from System.Text.Json 8.0+.

  • Adds JsonNodeSqlSerializer
  • JObjectSqlSerializer now doesn't format inner serialized JArrays/JObjects (with line breaks/indentations)

To be processed after #4766

Type of change

Please delete options that are not relevant.

  • [] New feature (non-breaking change which adds functionality)

Closing issues

Contributes to #4678

juraj-blazek and others added 30 commits September 12, 2024 13:41
~ reduce validations overhead
~ update api file
~ Microsoft.Azure.Cosmos.Encryption.Custom now references System.Text.Json 8.0.5 as per security advisory
@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli kirankumarkolli merged commit 4f515bb into Azure:master Oct 10, 2024
23 checks passed
@JanHyka JanHyka deleted the users/jan-hyka/jsonnode_serializer branch October 11, 2024 19:51
kirankumarkolli pushed a commit that referenced this pull request Oct 15, 2024
# Pull Request Template

## Description

- Added support for System.Text.JsonNode DOM on encryption path
- Configuration option to select Json Processor (defaults to Newtonsoft)
- Custom byte[] coverter supporting offset+length for JsonNode
- Perf tests expanded to cover both json processors (JsonNode decryption
still uses Newtonsoft, this will be upgraded with further PRs)

To be processed after #4779 

## Type of change

Please delete options that are not relevant.

- [] New feature (non-breaking change which adds functionality)
- [] This change requires a documentation update

## Closing issues

Contributes to #4678

---------

Co-authored-by: Juraj Blazek <jublazek@microsoft.com>
Co-authored-by: juraj-blazek <53177060+juraj-blazek@users.noreply.github.com>
Co-authored-by: Santosh Kulkarni <66682828+kr-santosh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants