Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] CI: Adds .NET8 SDK support #4776

Merged
merged 12 commits into from
Oct 9, 2024
Merged

[INTERNAL] CI: Adds .NET8 SDK support #4776

merged 12 commits into from
Oct 9, 2024

Conversation

kirankumarkolli
Copy link
Member

@kirankumarkolli kirankumarkolli commented Oct 9, 2024 •
edited
Loading

[INTERNAL] CI: Adds .NET8 SDK support

RISK: not all pipelines are exercised part of CI gates and might be surprises later.

Pilchie
Pilchie reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to actually run the tests with both, instead of just building with the .NET 8 SDK?

azure-pipelines-encryption-custom.yml Outdated Show resolved Hide resolved
@kirankumarkolli
Copy link
Member Author

Do we want to actually run the tests with both, instead of just building with the .NET 8 SDK?
That's next follow-up PR.

NaluTripician
NaluTripician approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@NaluTripician NaluTripician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirankumarkolli kirankumarkolli merged commit 2b0a021 into master Oct 9, 2024
23 checks passed
@kirankumarkolli kirankumarkolli deleted the users/kirankk/net8 branch October 9, 2024 20:30
@kirankumarkolli kirankumarkolli mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

@NaluTripician NaluTripician NaluTripician approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@khdang khdang Awaiting requested review from khdang

@adityasa adityasa Awaiting requested review from adityasa

@neildsh neildsh Awaiting requested review from neildsh

@kirillg kirillg Awaiting requested review from kirillg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirankumarkolli @Pilchie @NaluTripician