Query: Fixes ResponseMessage not parsing the IndexMetrics as text in latest sdk #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leminh98
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
ealsur
reviewed
Apr 10, 2024
adityasa
reviewed
Apr 10, 2024
...ft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/IndexMetricsParserBaselineTest.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Apr 10, 2024
adityasa
reviewed
Apr 10, 2024
...ft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/IndexMetricsParserBaselineTest.cs
Outdated
Show resolved
Hide resolved
Maya-Painter
approved these changes
Apr 11, 2024
leminh98
added
auto-merge
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Newer version of SDKs expects IndexMetrics header to come back as full text instead of base64. A code path on ResponseMessage was still parsing the IndexMetrics as base64, causing FormatException error. This PR addresses that issue
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4396