GlobalEndpointManager: Fixes Memory Leak #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
…per will get disposed before requests go through
FabianMeiswinkel
requested changes
Dec 27, 2023
microsoft-github-policy-service
bot
deleted the
users/nalutripician/cancellationTokenMemoryLeakFix
branch
NaluTripician
changed the title
NaluTripician
added a commit
that referenced
this pull request
Jan 2, 2024
* memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * changelog + version bump * genAPI * remove code changes * removed nit --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
NaluTripician
added a commit
that referenced
this pull request
Jan 3, 2024
* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * changelog + version bump * genAPI * remove code changes * removed nit --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
NaluTripician
added a commit
that referenced
this pull request
Jan 3, 2024
* memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
NaluTripician
added a commit
that referenced
this pull request
Jan 3, 2024
* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * changelog + version bump * genAPI * remove code changes * removed nit --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
NaluTripician
added a commit
that referenced
this pull request
Jan 3, 2024
* memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
* SDK 3.37.1 : Adds version bump and changelog (#4231) * [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * changelog + version bump * genAPI * remove code changes * removed nit --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
* SDK 3.37.1 : Adds version bump and changelog (#4231) * [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * changelog + version bump * genAPI * remove code changes * removed nit --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> * [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226) * memory leak fix * removed commented out code * changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through * added thread saftey * fixed to interlock pattern --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com> --------- Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This will fix the memory leak in
GlobalEndpointManagerwhereCancellationTokenSourcesare not disposed.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber