-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosOperationCanceledException: Adds serializable functionality #3433
CosmosOperationCanceledException: Adds serializable functionality #3433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Show resolved
Hide resolved
…ality upon deserialization
Bot not reacting to title change
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosOperationCanceledTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Outdated
Show resolved
Hide resolved
…dExceptionSerialization
…dExceptionSerialization
@NaluTripician See the test failures:
Because you are modifying a public type, this generates a change in the API contract, please run the Powershell the test indicates that should be in the root of your clone. |
…ialization' of https://github.com/Azure/azure-cosmos-dotnet-v3 into users/nalutripician/CosmosOperationCanceledExceptionSerialization
Pull Request Template
Description
Code changes to make the
CosmosOperationCanceledException
Exception serializable. It should be noted thatCosmosDiagnostics
are not serializable and are left out of sterilization and upon deserialization the originalCosmosDiagnotics
are replaced with aCosmosTraceDiagnostics
with aNoOpTrace
.lazyMessage
andtoStringMessage
for deserializedCosmosOperationCanceledException
s are also updated to inform users thatCosmosDiagnostics
cannot be deserialized. AdditionallyCosmosOperationCanceledTests.cs
was also created to test that the relevant information can be serialized and recovered.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3402