Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preview] Change Feed: Refactors Change Feed Contract to rename TimeToLiveExpired #3394

Merged
merged 2 commits into from
Aug 19, 2022
Merged

[Preview] Change Feed: Refactors Change Feed Contract to rename TimeToLiveExpired #3394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d501873
Code changes to update change feed metadata contract.
kundadebdatta Aug 19, 2022
3a6a0e9
Code changes to match contract changes with incoming json.
kundadebdatta Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Code changes to match contract changes with incoming json.
  • Loading branch information
@kundadebdatta
kundadebdatta committed Aug 19, 2022
commit 3a6a0e915e1f1fdb3618a711a29e53034fff293f
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public ChangeFeedMetadata(
/// <summary>
/// Used to distinquish explicit deletes (e.g. via DeleteItem) from deletes caused by TTL expiration (a collection may define time-to-live policy for documents).
/// </summary>
[JsonProperty(PropertyName = "isTimeToLiveExpired", NullValueHandling= NullValueHandling.Ignore)]
[JsonProperty(PropertyName = "timeToLiveExpired", NullValueHandling= NullValueHandling.Ignore)]
public bool IsTimeToLiveExpired { get; }
}
}
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
],
"MethodInfo": "Boolean get_IsTimeToLiveExpired();IsAbstract:False;IsStatic:False;IsVirtual:False;IsGenericMethod:False;IsConstructor:False;IsFinal:False;"
},
"Boolean IsTimeToLiveExpired[Newtonsoft.Json.JsonPropertyAttribute(NullValueHandling = 1, PropertyName = \"isTimeToLiveExpired\")]": {
"Boolean IsTimeToLiveExpired[Newtonsoft.Json.JsonPropertyAttribute(NullValueHandling = 1, PropertyName = \"timeToLiveExpired\")]": {
"Type": "Property",
"Attributes": [
"JsonPropertyAttribute"
Expand Down