Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct: Adds version 3.29.0 #3308

Merged
merged 11 commits into from
Jul 5, 2022

Conversation

imanvt
Copy link
Contributor

@imanvt imanvt commented Jun 27, 2022

Pull Request Template

Description

  • Adds Direct Version 3.29.0, which upgrades System.Configuration.ConfigurationManager dependency from 4.7.0 to 6.0.0
    • This dependency version is tied to the .NET 6.0 release, which still supports .NET Standard 2.0, so it is not a breaking change.
    • This dependency was upgraded due to a security/compliance alert.
  • Performance: Replaces DateTime.UtcNow.ToString("r") with Rfc1123DateTimeCache.UtcNow()
  • Fixes ObjectDisposedException during Bounded Staleness/Strong barrier requests

Micro Benchmark Test Results:

Method Mean Error StdDev Median Gen 0 Allocated
DateTimeToString 58.878 ns 1.9800 ns 5.8070 ns 57.634 ns 0.0185 80 B
Rfc1123DateTimeCacheUtcNow 2.298 ns 0.0778 ns 0.2280 ns 2.228 ns - -

Type of change

  • New feature (non-breaking change which adds functionality)

Closing issues

Part 1 of 2 for Issue #3274

@imanvt imanvt marked this pull request as ready for review June 30, 2022 14:04
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question regarding version upgrade

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabianMeiswinkel FabianMeiswinkel merged commit 1676475 into master Jul 5, 2022
@LeszekKalibrate
Copy link

LeszekKalibrate commented Jan 31, 2023

Adds Direct Version 3.29.0, which upgrades System.Configuration.ConfigurationManager dependency from 4.7.0 to 6.0.0
This is a breaking change when the CosmosDB SDK is used in Azure Function .Net Core 3.1.

Executed 'LoadFunction' (Failed, Id=a7e0c72d-6b72-410c-93da-5354dab1687d, Duration=1242ms) [2023-01-31T16:38:49.682Z] Microsoft.Azure.Cosmos.Client: Could not load file or assembly 'System.Configuration.ConfigurationManager, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants