Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Encryption: Adds code to fix breaking changes introduced in public surface client encryption policy APIs #3266

Merged
merged 21 commits into from
Jun 14, 2022

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented Jun 14, 2022

Description

This PR introduces additional client encryption policy constructors to avoid breaking changes required for minor version release.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] This change requires a documentation update

@kr-santosh kr-santosh changed the title Client Encryption: Adds code to fix break changes introduced in public surface client encryption policy APIs Client Encryption: Adds code to fix breaking changes introduced in public surface client encryption policy APIs Jun 14, 2022
abhijitpai
abhijitpai previously approved these changes Jun 14, 2022
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except for the NIT on the ctor overload - I have made suggestions that you can directly merge if you agree.

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ealsur ealsur enabled auto-merge (squash) June 14, 2022 13:55
@ealsur ealsur merged commit 0191140 into master Jun 14, 2022
@ealsur ealsur deleted the users/sakulk/coreSdkCepVer2 branch June 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants