Change Feed Processor: Adds Task.Delay check to prevent stalling #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/FeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/FeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/FeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
imanvt
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
FabianMeiswinkel and
kirillg
as code owners
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/FeedProcessing/FeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 14, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 14, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 14, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/FeedProcessorCoreTests.cs
Outdated
Show resolved
Hide resolved
added 2 commits
June 14, 2022 18:48
…ls instead of stalling when broken
ealsur
approved these changes
Jun 15, 2022
ealsur
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In some situations, the lease processor gets stuck, but the lease renewer keeps working. To prevent this situation from stalling indefinitely, this PR adds a linked cancellation token source to the cancellation token in order to cancel it after some time.
Type of change
Closing issues
closes #2466