Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Encryption: Adds code to support PartitionKey and Id encryption. #3241

Merged
merged 76 commits into from
Jul 26, 2022
Merged

Client Encryption: Adds code to support PartitionKey and Id encryption. #3241

merged 76 commits into from
Jul 26, 2022

Conversation

kr-santosh
Copy link
Contributor

Description

This PR brings in necessary changes to support partition key and id field encryption which is currently not supported.

Type of change

  • [] New feature (non-breaking change which adds functionality)
  • [] This change requires a documentation update

@kr-santosh kr-santosh changed the title [Waiting on Sdk Pkg][In Progress] Client Encryption: Adds code to support PartitionKey and Id encryption. Client Encryption: Adds code to support PartitionKey and Id encryption. Jun 13, 2022
@kr-santosh kr-santosh marked this pull request as ready for review June 15, 2022 06:13
FabianMeiswinkel
FabianMeiswinkel previously approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM except for a few comments.

abhijitpai
abhijitpai previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@abhijitpai abhijitpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ealsur ealsur enabled auto-merge (squash) July 26, 2022 15:35
@ealsur ealsur merged commit 78fc16c into master Jul 26, 2022
@ealsur ealsur deleted the users/sakulk/encPkgCepVer2 branch July 26, 2022 16:15
@aayush3011 aayush3011 mentioned this pull request Nov 2, 2022
Closed
6 tasks
@aayush3011 aayush3011 mentioned this pull request Feb 21, 2023
Merged
6 tasks
kr-santosh added a commit to kr-santosh/azure-docs that referenced this pull request Mar 10, 2023
@kr-santosh
Update how-to-always-encrypted.md
3c8c101 
Remove note, which says cannot encrypt Id and Partition key. This support was introduced in version 2.0.0.

 Azure/azure-cosmos-dotnet-v3#3241
@kr-santosh kr-santosh mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@abhijitpai abhijitpai abhijitpai left review comments

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel left review comments

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@j82w j82w Awaiting requested review from j82w

@kirillg kirillg Awaiting requested review from kirillg

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kr-santosh @abhijitpai @ealsur @FabianMeiswinkel