-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Encryption: Adds code to support PartitionKey and Id encryption. #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-santosh
changed the title
[Waiting on Sdk Pkg][In Progress] Client Encryption: Adds code to support PartitionKey and Id encryption.
Client Encryption: Adds code to support PartitionKey and Id encryption.
Jun 13, 2022
…/azure-cosmos-dotnet-v3 into users/sakulk/encPkgCepVer2
kr-santosh
requested review from
kirankumarkolli,
j82w,
ealsur and
FabianMeiswinkel
as code owners
June 15, 2022 06:13
…/azure-cosmos-dotnet-v3 into users/sakulk/encPkgCepVer2
FabianMeiswinkel
previously approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - LGTM except for a few comments.
abhijitpai
reviewed
Jul 25, 2022
Microsoft.Azure.Cosmos.Encryption/src/EncryptionFeedIterator.cs
Outdated
Show resolved
Hide resolved
abhijitpai
previously approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ealsur
approved these changes
Jul 26, 2022
6 tasks
6 tasks
kr-santosh
added a commit
to kr-santosh/azure-docs
that referenced
this pull request
Mar 10, 2023
Remove note, which says cannot encrypt Id and Partition key. This support was introduced in version 2.0.0. Azure/azure-cosmos-dotnet-v3#3241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in necessary changes to support partition key and id field encryption which is currently not supported.
Type of change