Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Encryption: Adds fix to retain the original key vault error/exception and upgrades core SDK package dependency. #3200

Merged
merged 22 commits into from
Jun 1, 2022

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented May 17, 2022

Description

This PR brings in following changes to fix

  • original failure/exception was not logged during unwrap/wrap call failure (revocation, no access etc).
  • updates the supported Core SDK Package dependency.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@kr-santosh kr-santosh changed the title [Internal] Client Encryption: Run encryption/decryption tasks in parallel. [Internal] Client Encryption: Adds changes to run encryption/decryption tasks in parallel. May 17, 2022
@github-actions github-actions bot dismissed stale reviews from themself May 17, 2022 09:36

All good!

@kr-santosh kr-santosh marked this pull request as ready for review May 17, 2022 11:42
@kr-santosh kr-santosh marked this pull request as draft May 18, 2022 02:47
@kr-santosh kr-santosh changed the title [Internal] Client Encryption: Adds changes to run encryption/decryption tasks in parallel. [Internal] Client Encryption: Adds fix to retain the original key vault error/exception and upgrades core SDK package dependency. May 20, 2022
abhijitpai
abhijitpai previously approved these changes May 23, 2022
abhijitpai
abhijitpai previously approved these changes May 26, 2022
abhijitpai
abhijitpai previously approved these changes May 30, 2022
@kr-santosh kr-santosh requested a review from ealsur May 31, 2022 03:13
@kr-santosh kr-santosh requested review from ealsur and j82w June 1, 2022 15:05
@ealsur ealsur enabled auto-merge (squash) June 1, 2022 15:12
@kr-santosh kr-santosh requested a review from ealsur June 1, 2022 15:17
@ealsur ealsur merged commit e50fbaa into master Jun 1, 2022
@ealsur ealsur deleted the users/sakulk/thrdCryptoOp branch June 1, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants