Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preview] Change Feed: Adds SDK changes required for Full-Fidelity Change Feed #3197

Merged
merged 40 commits into from
Aug 1, 2022
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
7838f35
new wire format implementation and tests
philipthomas-MSFT Mar 1, 2022
42b169c
default gateway mode on FFCF
philipthomas-MSFT May 16, 2022
b59dea9
new wire format implementation and tests
philipthomas-MSFT Mar 1, 2022
284517c
default gateway mode on FFCF
philipthomas-MSFT May 16, 2022
51970ef
removing some comments
philipthomas-MSFT May 16, 2022
2c9be66
various changes based on PR feedback
philipthomas-MSFT May 17, 2022
09d3549
changed metadata to changefeedmetadata based on PR feedback
philipthomas-MSFT May 17, 2022
993dc26
renaming public contract for metadata, current and previous lsn
philipthomas-MSFT May 17, 2022
7011062
itemchanges converter/resolver/serializer changes. changes to use Uni…
philipthomas-MSFT May 18, 2022
5b3691c
left out a summary on metadata
philipthomas-MSFT May 18, 2022
e0177c9
removed comments
philipthomas-MSFT May 18, 2022
1046526
removed unnecessary using directive
philipthomas-MSFT May 18, 2022
8e64a82
adding comment explaining why we are defaulting gateway mode for full…
philipthomas-MSFT May 18, 2022
1422b00
small correction on comment
philipthomas-MSFT May 18, 2022
60ced7e
removed unnecessar using directive
philipthomas-MSFT May 18, 2022
caf7b87
add summary
philipthomas-MSFT May 18, 2022
ab6a83f
did not need UserSerializer, i think. will pu some thought on it
philipthomas-MSFT May 19, 2022
f6fa2d4
main change was reverting AllOperations back to FullFidelity. Intenti…
philipthomas-MSFT May 24, 2022
94f8bc8
removed datetmeoffsetconverter(again), some formatting issues, renami…
philipthomas-MSFT May 24, 2022
4425a78
proposing we keep user serializer enabled that works for container op…
philipthomas-MSFT Jun 1, 2022
4f32fa8
removed whitelist condition in CosmosSerializer
philipthomas-MSFT Jun 1, 2022
22cd9ff
fix some tests
philipthomas-MSFT Jun 1, 2022
8860488
reverting back to JsonProperty and whitelisting ChangeFeedItemChanges<T>
philipthomas-MSFT Jun 3, 2022
1c12bbe
include TTL. However, I feel that the testing needs revisting because…
philipthomas-MSFT Jun 6, 2022
c0b69ab
removed a dup test that was breaking due to wire format metadata chan…
philipthomas-MSFT Jun 6, 2022
c362617
running UpdateContracts.ps1
philipthomas-MSFT Jun 9, 2022
178a168
re-ran UpdateContracts.ps1 while using the public cosmos db emulator …
philipthomas-MSFT Jun 13, 2022
8068ae9
some tests changes mostly
philipthomas-MSFT Jun 13, 2022
1e46776
add example and remarks for ChangeFeedItemChanges<>
philipthomas-MSFT Jun 13, 2022
ba1b630
running UpdateContract.ps1 again after the last change
philipthomas-MSFT Jun 20, 2022
feebdb6
Update Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTe…
philipthomas-MSFT Jun 22, 2022
37e1f04
removing Current from CurrentLogSequenceNumber; changing comment on P…
philipthomas-MSFT Jun 22, 2022
884068a
Merge branch 'users/philipthomas/fullfidelitycfp' of https://github.c…
philipthomas-MSFT Jun 22, 2022
146196b
re-running UpdateContracts.ps1 for the LogSequenceNumber change from …
philipthomas-MSFT Jun 29, 2022
1d2da2b
Merge branch 'master' into users/philipthomas/fullfidelitycfp
philipthomas-MSFT Jul 26, 2022
364f913
fixed a test because of the emulator change to include deleted operat…
philipthomas-MSFT Jul 28, 2022
4f33d82
Merge branch 'master' into users/philipthomas/fullfidelitycfp
philipthomas-MSFT Jul 28, 2022
11d48f1
Changed ChangeFeedItemChanges to singluar
philipthomas-MSFT Jul 28, 2022
c9cbd95
Merge branch 'users/philipthomas/fullfidelitycfp' of https://github.c…
philipthomas-MSFT Jul 28, 2022
2102b7b
renaming to Lsn
philipthomas-MSFT Jul 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed a test because of the emulator change to include deleted operat…
…ions in FFCF metadata
  • Loading branch information
philipthomas-MSFT committed Jul 28, 2022
commit 364f91341683b39b3b15bcbeda27099ad165252c
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ public async Task ChangeFeedIteratorCore_FeedRange_FromPartitionKey_Dynamic_Veri

ChangeFeedIteratorCoreTests.AssertGatewayMode(feedResponse);

Assert.AreEqual(expected: 2, actual: itemChanges.Count);
Assert.AreEqual(expected: 3, actual: itemChanges.Count);

ChangeFeedItemChanges<Item> createOperation = itemChanges[0];

Expand All @@ -1061,13 +1061,22 @@ public async Task ChangeFeedIteratorCore_FeedRange_FromPartitionKey_Dynamic_Veri
Assert.AreEqual(expected: "Atlanta", actual: replaceOperation.Current.City);
Assert.AreEqual(expected: "GA", actual: replaceOperation.Current.State);
Assert.AreEqual(expected: "30363", actual: replaceOperation.Current.ZipCode);
Assert.IsNotNull(createOperation.Metadata);
Assert.IsNotNull(replaceOperation.Metadata);
Assert.AreEqual(expected: ChangeFeedOperationType.Replace, actual: replaceOperation.Metadata.OperationType);
Assert.AreNotEqual(notExpected: default, actual: replaceOperation.Metadata.ConflictResolutionTimestamp);
Assert.AreNotEqual(notExpected: default, actual: replaceOperation.Metadata.LogSequenceNumber);
Assert.AreNotEqual(notExpected: default, actual: replaceOperation.Metadata.PreviousLogSequenceNumber);
Assert.IsFalse(replaceOperation.Metadata.TimeToLiveExpired);

ChangeFeedItemChanges<Item> deleteOperation = itemChanges[2];

Assert.IsNotNull(deleteOperation.Metadata);
Assert.AreEqual(expected: ChangeFeedOperationType.Delete, actual: deleteOperation.Metadata.OperationType);
Assert.AreNotEqual(notExpected: default, actual: deleteOperation.Metadata.ConflictResolutionTimestamp);
Assert.AreNotEqual(notExpected: default, actual: deleteOperation.Metadata.LogSequenceNumber);
Assert.AreNotEqual(notExpected: default, actual: deleteOperation.Metadata.PreviousLogSequenceNumber);
Assert.IsFalse(replaceOperation.Metadata.TimeToLiveExpired);

break;
}
}
Expand Down