-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientEncryption: Adds support for preview and non-preview version of Cosmos SDK in Encryption package. #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure-cosmos-dotnet-v3 into supportPreviewNonPreview
abhijitpai
reviewed
Mar 8, 2022
abhijitpai
reviewed
Mar 8, 2022
kr-santosh
commented
Mar 8, 2022
<PropertyGroup> | ||
<SigningType>Product</SigningType> | ||
<SignAssembly>true</SignAssembly> | ||
<DelaySign>true</DelaySign> | ||
<AssemblyOriginatorKeyFile>..\..\35MSSharedLib1024.snk</AssemblyOriginatorKeyFile> | ||
<GeneratePackageOnBuild>True</GeneratePackageOnBuild> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this.
…zure-cosmos-dotnet-v3 into supportPreviewNonPreview
kr-santosh
requested review from
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
March 15, 2022 06:07
abhijitpai
reviewed
Mar 15, 2022
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Mar 15, 2022
abhijitpai
previously approved these changes
Mar 15, 2022
j82w
reviewed
Mar 17, 2022
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Show resolved
Hide resolved
j82w
previously approved these changes
Mar 18, 2022
ealsur
reviewed
Mar 21, 2022
ealsur
requested changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on the yml file confirmation
j82w
previously approved these changes
Mar 22, 2022
j82w
reviewed
Mar 22, 2022
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Mar 22, 2022
j82w
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for both preview and non-preview version of Cosmos SDK in Encryption package and adds the pipeline to build the preview and non preview nuget packages.
Type of change