Client Encryption : Adds MDE library code in Encryption Project to take direct dependency on code and not on MDE nuget package. #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes to make it internal and adds header.
kr-santosh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
kirankumarkolli
previously approved these changes
Jan 5, 2022
j82w
reviewed
Jan 5, 2022
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Outdated
Show resolved
Hide resolved
j82w
reviewed
Jan 5, 2022
...ft.Azure.Cosmos.Encryption/src/MdeSrc/AzureKeyVaultProvider/AzureKeyVaultKeyStoreProvider.cs
Show resolved
Hide resolved
kr-santosh
dismissed stale reviews from kirankumarkolli and abhijitpai
via
9d18e52
j82w
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the MDE library code directly into Always Encrypted Cosmos DB project and removes the nuget dependency. This is to align with GA contract since MDE has not been GA'd yet. All the relevant files have been directly copied and all the public classes have been made internal.
FixMdePublicInterfaces.ps1 can be run if new files are to be added or if you need to merge fixes into this code by just replacing the files. This script adds the required header to exclude StyleCop checks and makes public classes internal.
Type of change