Diagnostics: Adds performance improvement to GetContactedRegions() #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
sourabh1007
changed the title
sourabh1007
changed the title
sourabh1007
force-pushed
the
users/sourabhjain/regioncontactedOptimization
branch
8 times, most recently
from
43a0269
to
d084f31
Compare
sourabh1007
changed the title
|
What's the impact with-out regions-contracted collection in telemetry? |
...Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Performance.Tests/Benchmarks/TelemetryBenchmark.cs
Outdated
Show resolved
Hide resolved
#2952 This issue has RCA documented. |
FabianMeiswinkel
requested changes
Dec 30, 2021
This reverts commit 3680d0f.
sourabh1007
force-pushed
the
users/sourabhjain/regioncontactedOptimization
branch
from
3680d0f
to
4ede83e
Compare
j82w
reviewed
Jan 11, 2022
j82w
reviewed
Jan 11, 2022
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosTraceDiagnostics.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Jan 12, 2022
...Microsoft.Azure.Cosmos.Performance.Tests/Benchmarks/RegionContactedInDiagnosticsBenchmark.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/TraceJoiner.cs
Show resolved
Hide resolved
j82w
approved these changes
Jan 12, 2022
j82w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Getting region Contacted information from the diagnostics is very inefficient today. It is affecting Client Telemetry Performance by 2% to 3% .
Right now, Overall impact is 5% (Comparing run with Telemetry and Without Telemetry)
Performance Test:
Without Change:
After this change:
Reduction in memory allocation and increase RPS is noticed for this particular function.
Client Telemetry Stats (Calculating Overall Impact after the Change):
Impact in % is:
Maxima Difference = 10599 (w/o Telemetry) - 10120 (with Telemetry) = 479 = 4.5%
Minima Difference = 8528 (w/o Telemetry) - 8867 (with Telemetry) = -339 = 0%
Type of change
Closing issues
To automatically close an issue: closes #2846 and closes #2952