-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Encryption: Adds an abstraction layer to hide the underlying usage of Microsoft Data Encryption(MDE) library. #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osmosEncryptionKeyStoreProviderCore
kr-santosh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
November 24, 2021 13:06
j82w
reviewed
Nov 29, 2021
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Show resolved
Hide resolved
j82w
reviewed
Nov 29, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/CosmosKeyEncryptionKeyAlgorithm.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/CosmosDataEncryptionKeyAlgorithm.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/CosmosEncryptionKeyStoreProviderCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/tests/EmulatorTests/MdeEncryptionTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/tests/EmulatorTests/MdeEncryptionTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/tests/EmulatorTests/MdeEncryptionTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/tests/EmulatorTests/MdeEncryptionTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Encryption/tests/EmulatorTests/MdeEncryptionTests.cs
Show resolved
Hide resolved
j82w
reviewed
Dec 7, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/EncryptionKeyStoreProviderImpl.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Dec 7, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/CosmosEncryptionKeyStoreProvider.cs
Outdated
Show resolved
Hide resolved
…al earlier, and fixed issue with ProtectedDataEncryptionKey cache time.
kr-santosh
commented
Dec 9, 2021
abhijitpai
reviewed
Dec 13, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/CosmosDataEncryptionKeyAlgorithm.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Dec 13, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/EncryptionKeyWrapProvider.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Dec 13, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/EncryptionKeyWrapProvider.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Dec 13, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/EncryptionKeyStoreProviderImpl.cs
Outdated
Show resolved
Hide resolved
…removes GetOrCreateDataEncryptionKey
abhijitpai
reviewed
Dec 15, 2021
Microsoft.Azure.Cosmos.Encryption/src/MdeSupport/EncryptionKeyStoreProviderImpl.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Dec 15, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUST FYI, V4 track alignment might leads some rework on dependency and contracts in future. |
kirankumarkolli
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in an abstraction layer to hide the underlying dependency on Microsoft Data Encryption library. The abstraction is limited to only the classes which are currently exposed to public methods of client side encryption SDK.
Type of change