Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public properties : Fixes public types to be upgrade safe so new content is not lost on deserialize and serialize paths. #2712

Merged
merged 13 commits into from
Sep 15, 2021
+765 −71
Merged

Public properties : Fixes public types to be upgrade safe so new content is not lost on deserialize and serialize paths. #2712

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b78b391
Add additional property to hold out of contract propertie while deser…
sourabh1007 Sep 8, 2021
27554a1
made this property internal and updated comment
sourabh1007 Sep 8, 2021
a847526
Add additional property for few more properties
sourabh1007 Sep 9, 2021
4c29cf3
add test
sourabh1007 Sep 10, 2021
f7aef47
fix test
sourabh1007 Sep 10, 2021
fa6742b
refactoring code
sourabh1007 Sep 11, 2021
5bc119f
added additional properties in more classes
sourabh1007 Sep 13, 2021
7d272cc
made dictionary comparision as an extension
sourabh1007 Sep 13, 2021
17aee8e
Update Microsoft.Azure.Cosmos/src/Util/DictionaryExtension.cs
sourabh1007 Sep 14, 2021
d906b6b
Update Microsoft.Azure.Cosmos/src/Util/DictionaryExtension.cs
sourabh1007 Sep 14, 2021
fdbfadb
rename extension func
sourabh1007 Sep 14, 2021
f87c86a
fix test
sourabh1007 Sep 15, 2021
c74307d
fix test
sourabh1007 Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@sourabh1007
sourabh1007 committed Sep 15, 2021
commit 4c29cf33d0ed3d585c17187a1de1288062368490
18 changes: 18 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/SettingsContractTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,24 @@ public void ContainerSettingsSimpleTest()
Assert.AreEqual(cosmosContainerSettings.PartitionKeyPath, collectionDeser.PartitionKey.Paths[0]);
}

[TestMethod]
public void ValidateAdditionalPropertiesAttributeInPropertiesFiles()
{
IEnumerable<Type> allClasses = from t in Assembly.GetAssembly(typeof(CosmosClient)).GetTypes()
where t.IsClass &&
t.IsPublic &&
!t.IsAbstract
where t.Name.EndsWith("Properties")
select t;

foreach(Type className in allClasses)
{
PropertyInfo property = className.GetProperty("AdditionalProperties", BindingFlags.NonPublic | BindingFlags.Instance);
sourabh1007 marked this conversation as resolved.
Show resolved Hide resolved
Assert.IsTrue(property != null);
sourabh1007 marked this conversation as resolved.
Show resolved Hide resolved
}
sourabh1007 marked this conversation as resolved.
Show resolved Hide resolved

}

[TestMethod]
public void SettingsDeserializeWithAdditionalDataTest()
{
Expand Down