Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark: Fixes build issues and adds gates #2698

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Sep 2, 2021

Pull Request Template

Description

The build is currently broken since it is referencing a field only available in the preview SDK. This fixes the build issue and adds gates to prevent future issues.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

ealsur
ealsur previously approved these changes Sep 2, 2021
templates/build-benchmark.yml Outdated Show resolved Hide resolved
templates/build-benchmark.yml Outdated Show resolved Hide resolved
@j82w j82w merged commit a591930 into master Sep 2, 2021
@j82w j82w deleted the users/jawilley/benchmarkFixes branch September 2, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants