Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Encryption : Removes retry during decryption failure. #2640

Merged
merged 7 commits into from
Aug 3, 2021

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented Jul 27, 2021

Description

Removes retry during decryption failure in DeserializeAndDecryptResponseAsync(). The retry logic around decryption was basically to address the problem with policy change and is handled by the caller in all cases except for ChangeFeedProcessor API set since we do not have Options to pass in the required headers. Will address this later with a better approach.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

@kr-santosh kr-santosh marked this pull request as ready for review July 27, 2021 08:02
@kr-santosh kr-santosh changed the title Client Encryption : Removes retry during decryption. Client Encryption : Removes retry during decryption failure. Jul 27, 2021
abhijitpai
abhijitpai previously approved these changes Jul 27, 2021
Copy link
Contributor

@abhijitpai abhijitpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@abhijitpai abhijitpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@j82w j82w merged commit b344afc into master Aug 3, 2021
@j82w j82w deleted the users/sakulk/bugfixes branch August 3, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants