Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINQ : Fixes ArgumentNullException while calling ToQueryDefinition() #2580

Merged
merged 5 commits into from
Jun 30, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ internal static QueryDefinition CreateFromQuerySpec(SqlQuerySpec sqlQuery)
{
if (sqlQuery == null)
{
throw new ArgumentNullException(nameof(sqlQuery));
// It is to support scenarios where all the data needs to be read
return null;
sourabh1007 marked this conversation as resolved.
Show resolved Hide resolved
}

QueryDefinition queryDefinition = new QueryDefinition(sqlQuery.QueryText);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,18 @@ async Task TestSearch(Expression<Func<ToDoActivity, bool>> expression, string ex

}

[TestMethod]
public async Task LinqSelectEverythingWithoutQueryableTest()
{
await ToDoActivity.CreateRandomItems(this.Container, pkCount: 2, perPKItemCount: 1, randomPartitionKey: true);

QueryDefinition queryDefinition = this.Container
.GetItemLinqQueryable<ToDoActivity>()
.ToQueryDefinition();

Assert.AreEqual(2, (await this.FetchResults<ToDoActivity>(queryDefinition)).Count);
}

private class NumberLinqItem
{
public string id;
Expand Down