Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAgent: Fixes race condition in ClientId and max value for UserAgentString #2574

Merged
merged 6 commits into from
Jun 25, 2021
Merged

UserAgent: Fixes race condition in ClientId and max value for UserAgentString #2574

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8576fda
Capping ClientId in UserAgentString
asketagarwal Jun 23, 2021
91aae51
fixing test
asketagarwal Jun 23, 2021
d49adb6
making clientId thread safe
asketagarwal Jun 24, 2021
4c2e8b7
fixing tests
asketagarwal Jun 24, 2021
e4faea5
fixing unit tests
asketagarwal Jun 24, 2021
67d3130
removing clientId from envInfo
asketagarwal Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing test
  • Loading branch information
@asketagarwal
asketagarwal committed Jun 23, 2021
commit 91aae51b7884fa59d64a85aeb12c4b6673961596
2 changes: 1 addition & 1 deletion Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/UserAgentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void VerifyUserAgentContent()
string[] values = serialization.Split('|');
Assert.AreEqual($"cosmos-netstandard-sdk/{envInfo.ClientVersion}", values[0]);
Assert.AreEqual(envInfo.DirectVersion, values[1]);
Assert.AreEqual(CosmosClient.numberOfClientsCreated.ToString(), values[2]);
Assert.AreEqual(Math.Min(CosmosClient.numberOfClientsCreated, 10).ToString(), values[2]);
Assert.AreEqual(envInfo.ProcessArchitecture, values[3]);
Assert.AreEqual(envInfo.OperatingSystem, values[4]);
Assert.AreEqual(envInfo.RuntimeFramework, values[5]);
Expand Down