Client Encryption: Adds ReadMany API support for encryption package. #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-santosh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
kr-santosh
changed the title
abhijitpai
reviewed
Jun 30, 2021
| @@ -889,6 +896,77 @@ internal sealed class EncryptionContainer : Container | |||
| cancellationToken: cancellationToken); | |||
| } | |||
|
|
|||
| internal async Task<Stream> DeserializeAndDecryptResponseAsync( | |||
There was a problem hiding this comment.
This is used by EncryptionFeedIterator... just moved the code above private methods..
abhijitpai
reviewed
Jun 30, 2021
| } | ||
|
|
||
| foreach (JToken value in documents) | ||
| // only clone it on the first try. |
abhijitpai
previously approved these changes
Jul 12, 2021
j82w
reviewed
Jul 12, 2021
Microsoft.Azure.Cosmos.Encryption/src/Custom/EncryptionContainer.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ReadMany API support for encryption package.
Type of change