-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Encryption: Adds support to use gateway cache to get client encryption key properties #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
changed the title
[Internal][Client Encryption]: Adds fix to carry out cached reads of client encryption key properties on the gateway cache.
Client Encryption: Adds support to use gateway cache to get client encryption key properties
May 25, 2021
kr-santosh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
June 22, 2021 10:33
abhijitpai
reviewed
Nov 16, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Nov 16, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Nov 29, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Nov 29, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
previously approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j82w
reviewed
Dec 1, 2021
Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettingForProperty.cs
Outdated
Show resolved
Hide resolved
abhijitpai
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j82w
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in the support to carry out cached reads of client encryption key properties on the gateway cache. The gateway houses a cache for client encryption key properties to reduce throttling on master partitions.
Type of change