-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Client Encryption : Adds test to verify that update of Client Encryption Policy is not allowed via ReplaceContainer #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujtoshniwal
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
March 30, 2021 10:06
abhijitpai
previously approved these changes
Mar 30, 2021
kr-santosh
previously approved these changes
Mar 30, 2021
anujtoshniwal
dismissed stale reviews from kr-santosh and abhijitpai
via
March 30, 2021 13:12
5e002f4
abhijitpai
previously approved these changes
Mar 31, 2021
j82w
reviewed
Mar 31, 2021
@@ -362,6 +362,7 @@ public async Task EncryptionResourceTokenAuthRestricted() | |||
} | |||
} | |||
|
|||
[Ignore] // will enable once the emulator is updated with latest code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get a new emulator released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling the tests. Milis mentioned that emulator will be upgraded most likely by tomorrow.
…om/Azure/azure-cosmos-dotnet-v3 into users/antoshni/addIntegrationTests
j82w
approved these changes
Apr 22, 2021
ealsur
pushed a commit
that referenced
this pull request
Jun 14, 2021
…ent Encryption Policy is not allowed via ReplaceContainer (#2349) Adds / updates existing tests to verify - a. Update of Client Encryption Policy is not allowed via ReplaceContainer b. CreateContainer request ensures that the ClientEncryptionKey exists when creating Client Encryption Policy
ealsur
pushed a commit
that referenced
this pull request
Jun 14, 2021
…ent Encryption Policy is not allowed via ReplaceContainer (#2349) Adds / updates existing tests to verify - a. Update of Client Encryption Policy is not allowed via ReplaceContainer b. CreateContainer request ensures that the ClientEncryptionKey exists when creating Client Encryption Policy
kirankumarkolli
pushed a commit
that referenced
this pull request
Jun 14, 2021
* Query: Fixes InvalidOperationException on merge to a single partition (#2510) * Add support to FlakyDocumentContainer send back 410s based on a delegate * Fix bug in CrossPartitionRangePageAsyncEnumerator where we dont handle a merge to a single partition * Fix InvalidOperationException on merge to single partition in OrderByCrossPartitionQueryPipelineStage * Incorporate CR feedback * more CR feedback Co-authored-by: Samer Boshra <sboshra@microsoft.com> * Query: Fixes handling of pipeline execution on partition merge (#2531) * fix * fixing inmemorycontainer * fixing merge test * undo small change * OrderBy fix too * Correct orderby handling * more tests * text Co-authored-by: j82w <j82w@users.noreply.github.com> * [Internal] Client Encryption : Adds test to verify that update of Client Encryption Policy is not allowed via ReplaceContainer (#2349) Adds / updates existing tests to verify - a. Update of Client Encryption Policy is not allowed via ReplaceContainer b. CreateContainer request ensures that the ClientEncryptionKey exists when creating Client Encryption Policy Co-authored-by: neildsh <35383880+neildsh@users.noreply.github.com> Co-authored-by: Samer Boshra <sboshra@microsoft.com> Co-authored-by: j82w <j82w@users.noreply.github.com> Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds / updates existing tests to verify -
a. Update of Client Encryption Policy is not allowed via ReplaceContainer
b. CreateContainer request ensures that the ClientEncryptionKey exists when creating Client Encryption Policy
Type of change