Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object #2345

Merged
merged 18 commits into from
Apr 19, 2021

Conversation

kr-santosh
Copy link
Contributor

@kr-santosh kr-santosh commented Mar 29, 2021

Description

  1. This PR removes the caching of AeadAes256CbcHmac256EncryptionAlgorithm object which was done earlier and now completely relies on MDE layer for caching.
  2. Upgrades to latest "Microsoft.Data.Encryption.Cryptography" Version="0.2.0-pre".

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] This change requires a documentation update

@abhijitpai
Copy link
Contributor

            false);

parameterName:


Refers to: Microsoft.Azure.Cosmos.Encryption/src/EncryptionSettings.cs:53 in 86ed4b5. [](commit_id = 86ed4b5, deletion_comment = False)

@abhijitpai
Copy link
Contributor

        this.EncryptionSettings = new EncryptionSettings();

If this settings map is a child of the processor, just pass it the processor here rather than passing it in every method.


Refers to: Microsoft.Azure.Cosmos.Encryption/src/EncryptionProcessor.cs:54 in 86ed4b5. [](commit_id = 86ed4b5, deletion_comment = False)

abhijitpai
abhijitpai previously approved these changes Mar 29, 2021
Copy link
Contributor

@abhijitpai abhijitpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

anujtoshniwal
anujtoshniwal previously approved these changes Apr 9, 2021
@j82w j82w changed the title Client Encryption : Adds integration with Latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object. Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object. Apr 19, 2021
@j82w j82w changed the title Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object. Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object Apr 19, 2021
@j82w j82w changed the title Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object Client Encryption : Add integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object Apr 19, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@j82w j82w changed the title Client Encryption : Add integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object Client Encryption : Adds integration with latest Cryptography package and removes caching of AeadAes256CbcHmac256EncryptionAlgorithm object Apr 19, 2021
@github-actions github-actions bot dismissed their stale review April 19, 2021 16:51

All good!

@j82w j82w merged commit 1aba91b into master Apr 19, 2021
@j82w j82w deleted the users/sakulk/removealgocaching branch April 19, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants