Batch API: Adds Session token support #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
rakkuma
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
rakkuma
changed the title
j82w
requested changes
Sep 23, 2020
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
ealsur
requested changes
Sep 23, 2020
Microsoft.Azure.Cosmos/src/Batch/TransactionalBatchRequestOptions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Sep 23, 2020
Microsoft.Azure.Cosmos/src/Batch/TransactionalBatchRequestOptions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Sep 23, 2020
Microsoft.Azure.Cosmos/src/Batch/TransactionalBatchRequestOptions.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Sep 25, 2020
|
Please resolve all comments |
bchong95
reviewed
Sep 26, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Batch/BatchTestBase.cs
Show resolved
Hide resolved
bchong95
reviewed
Sep 26, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Batch/BatchTestBase.cs
Show resolved
Hide resolved
ealsur
previously approved these changes
Sep 28, 2020
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
rakkuma
dismissed stale reviews from ealsur and kirankumarkolli
via
c48272e
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
j82w
previously approved these changes
Oct 8, 2020
abhijitpai
previously approved these changes
Oct 8, 2020
|
@rakkuma Can you fix the Emulator tests that are failing? They are throwing NullReferenceException |
…m/Azure/azure-cosmos-dotnet-v3 into users/rakkuma/batch-session-token
rakkuma
force-pushed
the
users/rakkuma/batch-session-token
branch
from
f3b8f35 to
a32289b
Compare
|
The change which enable few test cases are in 0901. So until the next emulator is built, we can wait. The current is build out of 0815. |
…m/Azure/azure-cosmos-dotnet-v3 into users/rakkuma/batch-session-token
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
…m/Azure/azure-cosmos-dotnet-v3 into users/rakkuma/batch-session-token
Signed-off-by: Rakesh Kumar <rakkuma@microsoft.com>
ealsur
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Please get a signoff from @kirankumarkolli due to the public API change
kirankumarkolli
approved these changes
Feb 12, 2021
This was referenced Mar 8, 2021
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session token support for transactional batch
Description
This adds support for passing session token for transactional Batch. In TransactionalBatchRequestOptions new option namely SessionToken is added.
Type of change
Closing issues
To automatically close an issue: closes #1567