LINQ : Adds support for case-insensitive searches #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpardy
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
|
|
|
@khdang Please also review this. |
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemLinqTests.cs
Show resolved
Hide resolved
bchong95
reviewed
Jul 23, 2020
|
Thanks for the quick review @bchong95 👍🏼 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
previously approved these changes
Jul 24, 2020
j82w
changed the title
|
Not sure if the failures are related, I get same errors running locally without the changes in this PR. |
|
@jeffpardy Which Emulator version are you using? |
|
@ealsur 2.11.2.0 (1dc428e8) |
j82w
previously approved these changes
Jul 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@jeffpardy for some reason, the license/cla check seems to be missing, did you sign the CLA? |
|
Yes, it was showing before here? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1721 in repo Azure/azure-cosmos-dotnet-v3 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
khdang
reviewed
Jul 30, 2020
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/StringBuiltinFunctions.cs
Outdated
Show resolved
Hide resolved
bchong95
previously approved these changes
Jul 30, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds LINQ support for case-insensitive overloads of:
https://devblogs.microsoft.com/cosmosdb/new-string-function-performance-improvements-and-case-insensitive-search/
Type of change
closes #1647