Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview contract: Add preview contract tests to CI #1674

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Preview contract: Add preview contract tests to CI #1674

merged 6 commits into from
Jun 30, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jun 29, 2020

Pull Request Template

Description

  1. Add preview contract tests for the SDK
  2. Removed the testbaseline.cmd variations and created a single powershell script to update everything. The script builds and runs the necessary tests then copies the correct files over. It builds both preview and official version to update both contracts
  3. Moved all contract tests to a single folder to make it easier to discover
  4. Added owners to the new contract folder

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@j82w j82w self-assigned this Jun 29, 2020
@j82w j82w changed the title DRAFT: Preview contract: Add preview contract tests to CI Preview contract: Add preview contract tests to CI Jun 29, 2020
ealsur
ealsur reviewed Jun 29, 2020
View reviewed changes
...rosoft.Azure.Cosmos.Tests/BaselineTest/TestBaseline/PipelineContinuationTokenTests.Tests.xml Show resolved Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/ContractEnforcement.cs Show resolved Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/ContractEnforcement.cs Show resolved Hide resolved
...re.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Diagnostics/CosmosDiagnosticsSerializerTests.cs Show resolved Hide resolved
UpdateContracts.ps1 Show resolved Hide resolved
UpdateContracts.ps1 Outdated Show resolved Hide resolved
UpdateContracts.ps1 Show resolved Hide resolved
templates/build-preview.yml Outdated Show resolved Hide resolved
templates/build-preview.yml Outdated Show resolved Hide resolved
@kirankumarkolli kirankumarkolli merged commit 37763a4 into master Jun 30, 2020
@kirankumarkolli kirankumarkolli deleted the users/jawilley/build/previewContract branch June 30, 2020 15:25
@j82w j82w mentioned this pull request Jul 1, 2020
Closed
4 tasks
kirankumarkolli pushed a commit that referenced this pull request Jul 11, 2020
@j82w @kirankumarkolli
Preview contract: Add preview contract tests to CI (#1674)
b448325 
* Add preview contract validation

* Move all contract tests to folder

* Fix updatecontracts script messages. Add bad contract to verify tests CI..

* Removed code coverage from preview unit tests

* Fixed preview contract
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@bchong95 bchong95 Awaiting requested review from bchong95

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees

@j82w j82w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j82w @ealsur @kirankumarkolli