Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] PR Requirements: Add PR title requirements to allow changelog generation #1322

Merged
merged 15 commits into from
Apr 3, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Mar 30, 2020

Pull Request Template

Description

To reduce conflicts and changelog mistakes the PR titles will be used as the changelog in the future. This will make is easier for users looking through the history and avoid merge conflicts on the changelog file. This will require the changelog to get generated for each release, but can be done as part of contract validation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

To reduce conflicts and changelog mistakes the PR titles will be used as the changelog in the future. This will make is easier for users looking through the history and avoid merge conflicts on the changelog file. This will require the changelog to get generated for each release, but can be done as part of contract validation.
@j82w j82w self-assigned this Mar 30, 2020
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@j82w j82w changed the title Updating PR template with PR title as changelog Fixed Updating PR template with PR title as changelog Apr 1, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format. [Internal] (Added|Fixed) Category: Description

@j82w j82w changed the title Fixed Updating PR template with PR title as changelog [Internal] Added PR Requirements: Updating PR template with PR title as changelog Apr 1, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format. [Internal] (Added|Fixed) Category: Description

ealsur
ealsur previously approved these changes Apr 2, 2020
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@j82w j82w dismissed stale reviews from FabianMeiswinkel and ealsur via 80f7766 April 2, 2020 23:41
@j82w j82w changed the title [Internal] Added PR Requirements: Updating PR template with PR title as changelog [Internal][Added] PR Requirements: Updating PR template with PR title as changelog Apr 2, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format. [Internal] (Added|Fixed) Category: Description

@j82w j82w changed the title [Internal][Added] PR Requirements: Updating PR template with PR title as changelog [Internal][Added] PR Requirements: to generate changelog from PR titles Apr 2, 2020
@j82w j82w changed the title [Internal][Added] PR Requirements: to generate changelog from PR titles [Internal] PR Requirements: Add PR title requirements to allow changelog generation Apr 3, 2020
@kirankumarkolli kirankumarkolli merged commit cf547f3 into master Apr 3, 2020
@kirankumarkolli kirankumarkolli deleted the j82w-changelog-to-pr-titles branch April 3, 2020 16:28
ealsur pushed a commit that referenced this pull request Apr 3, 2020
…log generation (#1322)

* Updating PR template with PR title as changelog

To reduce conflicts and changelog mistakes the PR titles will be used as the changelog in the future. This will make is easier for users looking through the history and avoid merge conflicts on the changelog file. This will require the changelog to get generated for each release, but can be done as part of contract validation.

* Updated based on feedback

* Fixed grammar

* More fixes

* Adding pr lint action

* Try single quotes to fix parse error

* Trying to move it to build yaml

* Try including all changes

* Updating

* Reverting changes

* updated based on feedback

* updating regex

* Removing space

* Updated based on user suggestion
ealsur added a commit that referenced this pull request Apr 3, 2020
…ration (#1341)

* [Internal] PR Requirements: Add PR title requirements to allow changelog generation (#1322)

* Updating PR template with PR title as changelog

To reduce conflicts and changelog mistakes the PR titles will be used as the changelog in the future. This will make is easier for users looking through the history and avoid merge conflicts on the changelog file. This will require the changelog to get generated for each release, but can be done as part of contract validation.

* Updated based on feedback

* Fixed grammar

* More fixes

* Adding pr lint action

* Try single quotes to fix parse error

* Trying to move it to build yaml

* Try including all changes

* Updating

* Reverting changes

* updated based on feedback

* updating regex

* Removing space

* Updated based on user suggestion

* porting pr

* breaklines

* examples

* examples

Co-authored-by: j82w <j82w@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants