-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing retry after for stream queries. #1263
Conversation
…ously the header would not get set in the query stream APIs.
@@ -192,10 +192,10 @@ private static string MergeErrorMessages(string message, Error error) | |||
|
|||
if (string.IsNullOrEmpty(message)) | |||
{ | |||
return error.Message; | |||
return error.ToString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that Error is a JSON bag and some error objects don't put it in the message so only ToString() shows it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…g tests in parallel.
Pull Request Template
Description
This fixes a bug where retry after was not getting set on throttle responses for
GetItemQueryStreamIterator
. Adds additional test to validate the retry after time is always set.Type of change
Please delete options that are not relevant.