Add Stream payload to ExecuteStoredProcedureStreamAsync

[joshlang]

Description

#1059

This adds an overload to ExecuteStoredProcedureStreamAsync which accepts a Stream payload representing the parameters. The original only accepted dynamic[], which must be serialized.

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Closing issues

closes #1059

[j82w]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[joshlang]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 1061 in repo Azure/azure-cosmos-dotnet-v3

[joshlang]

Worth a shot :D

[j82w]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[joshlang]

Wow, you guys have quite the test suite. I've updated my local environment so that I can actually run them all. Previously, most failed so I just ignored failures.

FYI Microsoft.Azure.Cosmos.Tests -> AsyncCacheTest -> TestCancelOnOneThreadCancelsOtherTaskIfCanceled still fails for me.

[joshlang]

Unrelated to this PR - just a question:

azure-cosmos-dotnet-v3/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/AsyncCacheTest.cs

Line 168 in 94d517b

Assert.IsFalse(getTask1.IsCompleted);

This assertion is what fails the test when I run it locally.

The assertion doesn't seem to make sense - it's a race condition at best. After the cancellationTokenSource is .Cancel()'ed, getTask1 can complete at any time, including immediately.

What's your approach to stuff like this? Leave it alone unless it's actually causing trouble in the pipeline? Raise an issue and let the test owner fix it? Hope for a PR lol?

[j82w]

Create an issue for the failing test. Someone will investigate it. It probably won't be until next week. What's interesting is the test seems to be passing in the gates. Please make sure to put the OS you are running.

[j82w]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[joshlang]

Test failed due to ...Class Initialization method Microsoft.Azure.Cosmos.SDK.EmulatorTests.BatchSinglePartitionKeyTests.ClassInitialize threw exception. Microsoft.Azure.Cosmos.CosmosException: Microsoft.Azure.Cosmos.CosmosException: Response status code does not indicate success: 408 Substatus: 0 Reason: (Microsoft.Azure.Documents.RequestTimeoutException...

Probably transient.

[joshlang]

Could I get a friendly neighborhood /azp run por favor?

[j82w]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kirankumarkolli]

#1059 updated with more context and follow-up.

[joshlang]

changelog.md conflicts are now resolved.

[kirankumarkolli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kirankumarkolli]

@ealsur can you please take a look a the tests and any new coverage needed?

[joshlang]

Failing test - probably transient:

X TestReducePageSizeScenario [393ms]
  Error Message:
   Initialization method Microsoft.Azure.Cosmos.SDK.EmulatorTests.ChangeFeed.DynamicTests.TestInitialize threw exception. Microsoft.Azure.Cosmos.CosmosException: Response status code does not indicate success: 500 Substatus: 0 Reason: (Microsoft.Azure.Documents.DocumentClientException: Message: {"Errors":["An unknown error occurred while processing this request."]}
...

[ealsur]

/asp run

[joshlang]

/asp run

azp? :D

[ealsur]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[ealsur]

There seems to be a build error from the merge with master. ScriptsInlineCore needs to implement the new public method, it should be similar to the other Execute where TaskHelper is used to wrap the inner call (ref #1078)

[joshlang]

You silly goose, why do you update master behind my back :D

Ok, will investigate.

[ealsur]

Sorry! It should be as simple as:

public override Task<ResponseMessage> ExecuteStoredProcedureStreamAsync(
    string storedProcedureId,
    Stream streamPayload,
    PartitionKey partitionKey,
    StoredProcedureRequestOptions requestOptions = null,
    CancellationToken cancellationToken = default(CancellationToken));
{
    return TaskHelper.RunInlineIfNeededAsync(() => this.scripts.ExecuteStoredProcedureStreamAsync<TOutput>(storedProcedureId, streamPayload, partitionKey, requestOptions, cancellationToken));
}

[joshlang]

No problem. Synced up from Azure/master, made the changes and should be good to go

[ealsur]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[joshlang]

Various connectivity errors to nuget:

C:\Program Files\dotnet\sdk\3.1.100\NuGet.targets(123,5): error : Unable to load the service index for source https://api.nuget.org/v3/index.json. [D:\a\1\s\Microsoft.Azure.Cosmos.sln]


Failed to download package 'Microsoft.Azure.Cosmos.Serialization.HybridRow.1.0.0-preview' from 'https://www.myget.org/F/azure-cosmos/api/v3/flatcontainer/microsoft.azure.cosmos.serialization.hybridrow/1.0.0-preview/microsoft.azure.cosmos.serialization.hybridrow.1.0.0-preview.nupkg'.
         No connection could be made because the target machine actively refused it.

Either nuget has exploded permanently, or hopefully it's transient