Diagnostics: Adds startDate in Summary (#3707)

* Adding start date * Updated trace files * PR comment * Committing missing tests --------- Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
Azure · Feb 27, 2023 · 94c83f5 · 94c83f5
1 parent b257f8e
commit 94c83f5
Show file tree

Hide file tree

Showing 15 changed files with 66 additions and 65 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
@@ -46,8 +46,8 @@ public static void WriteTrace(
 
                 if (isRootTrace)
                 {
-                    writer.WriteFieldName("start time");
-                    writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString));
+                    writer.WriteFieldName("start datetime");
+                    writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateTimeFormatString));
                 }
                 writer.WriteFieldName("duration in milliseconds");
                 writer.WriteNumber64Value(trace.Duration.TotalMilliseconds);

diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs
@@ -18,6 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing
     internal static partial class TraceWriter
     {
         internal static readonly string HourTimeFormatString = "HH:mm:ss:fff";
+        internal static readonly string DateTimeFormatString = "yyyy-MM-ddTHH:mm:ss.fffZ";
 
         private static class TraceTextWriter
         {

diff --git a/...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml b/...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml
@@ -61,7 +61,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ExecuteAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...rTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml b/...rTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml
@@ -60,7 +60,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -218,7 +218,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -376,7 +376,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -534,7 +534,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -692,7 +692,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -850,7 +850,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1008,7 +1008,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1166,7 +1166,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1324,7 +1324,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1482,7 +1482,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1796,7 +1796,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...latorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml b/...latorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml
@@ -238,7 +238,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1124,7 +1124,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1738,7 +1738,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2340,7 +2340,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2888,7 +2888,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {

diff --git a/...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml b/...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml
@@ -44,7 +44,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateDatabaseAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -154,7 +154,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateDatabaseAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...lineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml b/...lineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml
@@ -68,7 +68,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -254,7 +254,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -514,7 +514,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -750,7 +750,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1029,7 +1029,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1267,7 +1267,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...s.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml b/...s.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml
@@ -163,7 +163,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -753,7 +753,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1356,7 +1356,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1947,7 +1947,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2577,7 +2577,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -3227,7 +3227,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -3827,7 +3827,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {

diff --git a/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml b/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml
@@ -139,7 +139,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -691,7 +691,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1256,7 +1256,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1809,7 +1809,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {

diff --git a/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadManyAsync.xml b/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadManyAsync.xml
@@ -138,7 +138,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ReadManyItemsStreamAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -696,7 +696,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ReadManyItemsAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.StreamPointOperationsAsync.xml b/...BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.StreamPointOperationsAsync.xml
@@ -41,7 +41,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemStreamAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -130,7 +130,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ReadItemStreamAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -227,7 +227,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ReplaceItemStreamAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -319,7 +319,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "DeleteItemStreamAsync",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"