Skip to content

Commit

Permalink
Transport: Fixes use of PortReuseMode and other Direct configuration …
Browse files Browse the repository at this point in the history
…settings (#1744)

Fix PortReuseMode and other TCP setting in connection policy to be honored by DocumentClient
  • Loading branch information
Liphi authored Jul 31, 2020
1 parent 9a75373 commit 49e290a
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions Microsoft.Azure.Cosmos/src/DocumentClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1027,36 +1027,36 @@ internal virtual void Initialize(Uri serviceEndpoint,
#endif

// ConnectionPolicy always overrides appconfig
if (this.ConnectionPolicy != null)
if (connectionPolicy != null)
{
if (this.ConnectionPolicy.IdleTcpConnectionTimeout.HasValue)
if (connectionPolicy.IdleTcpConnectionTimeout.HasValue)
{
this.idleConnectionTimeoutInSeconds = (int)this.ConnectionPolicy.IdleTcpConnectionTimeout.Value.TotalSeconds;
this.idleConnectionTimeoutInSeconds = (int)connectionPolicy.IdleTcpConnectionTimeout.Value.TotalSeconds;
}

if (this.ConnectionPolicy.OpenTcpConnectionTimeout.HasValue)
if (connectionPolicy.OpenTcpConnectionTimeout.HasValue)
{
this.openConnectionTimeoutInSeconds = (int)this.ConnectionPolicy.OpenTcpConnectionTimeout.Value.TotalSeconds;
this.openConnectionTimeoutInSeconds = (int)connectionPolicy.OpenTcpConnectionTimeout.Value.TotalSeconds;
}

if (this.ConnectionPolicy.MaxRequestsPerTcpConnection.HasValue)
if (connectionPolicy.MaxRequestsPerTcpConnection.HasValue)
{
this.maxRequestsPerRntbdChannel = this.ConnectionPolicy.MaxRequestsPerTcpConnection.Value;
this.maxRequestsPerRntbdChannel = connectionPolicy.MaxRequestsPerTcpConnection.Value;
}

if (this.ConnectionPolicy.MaxTcpPartitionCount.HasValue)
if (connectionPolicy.MaxTcpPartitionCount.HasValue)
{
this.rntbdPartitionCount = this.ConnectionPolicy.MaxTcpPartitionCount.Value;
this.rntbdPartitionCount = connectionPolicy.MaxTcpPartitionCount.Value;
}

if (this.ConnectionPolicy.MaxTcpConnectionsPerEndpoint.HasValue)
if (connectionPolicy.MaxTcpConnectionsPerEndpoint.HasValue)
{
this.maxRntbdChannels = this.ConnectionPolicy.MaxTcpConnectionsPerEndpoint.Value;
this.maxRntbdChannels = connectionPolicy.MaxTcpConnectionsPerEndpoint.Value;
}

if (this.ConnectionPolicy.PortReuseMode.HasValue)
if (connectionPolicy.PortReuseMode.HasValue)
{
this.rntbdPortReuseMode = this.ConnectionPolicy.PortReuseMode.Value;
this.rntbdPortReuseMode = connectionPolicy.PortReuseMode.Value;
}
}

Expand Down Expand Up @@ -7358,4 +7358,4 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage

#endregion
}
}
}

0 comments on commit 49e290a

Please sign in to comment.