[NPM] fix: Update Iptables to Legacy #3782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates iptables configuration to use legacy mode and upgrades the base Ubuntu image from 20.04 to 24.04. The changes address compatibility issues by switching from standard iptables commands to their legacy variants and updating dependencies accordingly.
- Updates iptables constants to use legacy variants (iptables-legacy, iptables-legacy-save, etc.)
- Upgrades Docker base image from Ubuntu 20.04 to 24.04 with specific package versions
- Updates development configuration and dependency versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| npm/util/const.go | Updates iptables command constants to use legacy variants |
| npm/linux.Dockerfile | Upgrades base image to Ubuntu 24.04 and pins specific package versions |
| hack/aks/Makefile | Changes IP tag from test to non-production environment |
| go.mod | Updates mapstructure dependency to v2.3.0 |
Comments suppressed due to low confidence (1)
npm/util/const.go:39
- The constant name 'IptablesRestoreNft' suggests NFT functionality, but the value 'iptables-legacy-nft-restore' mixes legacy and NFT concepts. Consider renaming to 'IptablesRestoreLegacyNft' to clarify this is the legacy version of the NFT restore command.
IptablesRestoreNft string = "iptables-legacy-nft-restore"
vakalapa
previously approved these changes
Jul 10, 2025
neaggarwMS
previously approved these changes
Jul 10, 2025
|
/azp run Azure Container Networking PR |
|
/azp run NPM Conformance Tests |
|
/azp run NPM Scale Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anubhabMajumdar
approved these changes
Jul 10, 2025
snguyen64
approved these changes
Jul 10, 2025
vakalapa
approved these changes
Jul 10, 2025
mereta
approved these changes
Jul 10, 2025
4 tasks
rayaisaiah
added a commit
that referenced
this pull request
Jul 17, 2025
* added legacy * typo * updated tests * updated for all tests
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Updates iptables to
legacyfix crashloopbackoffs inCBL-Mariner/Linuxnodepools.Issue Fixed:
NPM's Ubuntu base image was recently updated to
24.04from20.04as the older version was EOL (see: #3743). There was a behavioral change between the 2 Ubuntu versions that required NPM to specifylegacyfor its Iptables.Error: failed to create dataplane with error Operation [BootupDataplane] failed with error code [999], full cmd [], full error failed to reset policy dataplane: Operation [BootupPolicyManager] failed with error code [999], full cmd [], full error failed to bootup policy manager: failed to detect iptables version: unable to locate which iptables version kube proxy is usingRequirements:
Notes: