[Service Tags] ci: Update ACN to use Virtual Tags #3745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Cilium scenarios to use virtual tags by changing the assigned IP tag used in public IP configurations.
- Updated the IP_TAG value in the Makefile to reflect the new virtual tag context.
Comments suppressed due to low confidence (1)
hack/aks/Makefile:22
- Ensure that the updated tag value 'FirstPartyUsage=/NonProd' aligns with the intended virtual tag usage across the related configurations. Consider updating any associated documentation or configuration comments if necessary for clarity.
IP_TAG ?= FirstPartyUsage=/NonProd
k-routhu
changed the title
jpayne3506
changed the title
jpayne3506
changed the title
jpayne3506
added
needs-backport
jpayne3506
approved these changes
Jun 19, 2025
rayaisaiah
approved these changes
Jun 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
….5 (#3750) * ci: [Service Tags] add public ips with service tags for LBs during cluster creation (#3277) * Create an outbound public ip for LB/Cilium cluster * create and attach public ip for cilium e2e cluster * Test cluster independent ip creation * Test outbound public ip creation * Test outbound public ip creation * Test outbound public ip creation with azcli creds * Test outbound public ip creation with azcli creds * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add lb ip creation alias call for clusters in makefile * Add managed identity to public ip/load balancer * Add managed identity to public ip/load balancer * Test wo managed identity * Test wo managed identity * Add Public ip to one cluster * Add public to all cluster creations * Add public ip * Fix spacing * Fix spacing * Add LB to win cni v1 cluster * Add LB to win cni v1 cluster * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * Add ip-tag variable to makefile * updated service tag to 'DelegatedNetworkControllerTest' * create public IP as target * add ipv6 public ips to dualstack * updated v6 ip * remove space * added public ip for nodesubnet-byocni-nokubeproxy-up resource * addressed comments on PR * parameterize ip v4 & v6 Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Signed-off-by: Keerthana Routhu <111544828+k-routhu@users.noreply.github.com> * address comments * address PR comments * Update hack/aks/Makefile Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Signed-off-by: Keerthana Routhu <111544828+k-routhu@users.noreply.github.com> * test * test * test --------- Signed-off-by: Keerthana Routhu <111544828+k-routhu@users.noreply.github.com> Co-authored-by: shubham-pathak-03 <87148966+shubham-pathak-03@users.noreply.github.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> * [Service Tags] ci: Update ACN to use Virtual Tags (#3745) update to virtual tag * formatting * formatting * Update hack/aks/Makefile Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Keerthana Routhu <111544828+k-routhu@users.noreply.github.com> --------- Signed-off-by: Keerthana Routhu <111544828+k-routhu@users.noreply.github.com> Co-authored-by: shubham-pathak-03 <87148966+shubham-pathak-03@users.noreply.github.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Added virtual tags to all public ips. This change updates the previously added service tags (in this PR) to virtual tags since the public ips in these scenarios don't use NSGs, NSPs, or ACLs.
Testing:
Tested changes in a couple of pipelines:
Cilium Nightly Pipeline
Seems like all runs of this pipeline are currently failing but cluster creation (the main concern here) is happening successfully
CNI Release Test
A few scenarios are failing across all pipelines because of region capacity I believe. The remaining regions look okay for the most part.
ACN PR
CNI-LSG Integration
Was not expecting this test to pass -- just looking for successful cluster creation