Sql vm minor changes + new property in sql vm create #9875
Conversation
|
@tjprescott could you please help me review this PR?
But this is not related to my changes. Appreciate the help, we want to merge soon :) |
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -168,6 +175,9 @@ def load_arguments(self, _): | |||
| options_list=['--image-sku'], | |||
| help='SQL image sku.', | |||
| arg_type=get_enum_type(SqlImageSku)) | |||
| c.argument('sql_image_offer', | |||
| options_list=['--image-offer'], | |||
| help='SQL image offer. Examples include SQL2008R2-WS2008R2, SQL2008R2-WS2008, SQL2008-WS2008, SQL2008-WS2008R2.') | |||
There was a problem hiding this comment.
Where do these values come from? It seems like this might need to use the populator_commands kwarg in help.py.
There was a problem hiding this comment.
These were just examples of possible combinations. I reduced the amount of examples just to give an idea of what the pattern should look like.
There was a problem hiding this comment.
Is it purely pattern based? Is there an endpoint that provides actual supported values?
There was a problem hiding this comment.
No there is no endpoint that provides the supported values unfortunately. This parameter (image-offer) is only required if customer provides sql-mgmt-type as NoAgent, which is a minimal portion of customers (what we call End of Support Customers that have WS 2008).
This PR contains small changes as:
Adding a new property --sql-mgmt-type, not required with a default value.
Modifying tests accordingly.
Removing a deprecated parameter.
Small update in sql vm group that did not allow customers to set the new storage account key in update.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.