Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webapp: Adding validation to az webapp identity commands & other minor changes #9872

Merged
merged 5 commits into from
Jul 10, 2019

Conversation

panchagnula
Copy link
Contributor

@panchagnula panchagnula commented Jul 5, 2019

Fixes #8022, Fixes #6727, Fixes #9663

This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@panchagnula panchagnula force-pushed the sisirap-sprint65-fixes branch from 4ae4816 to 1e5c211 Compare July 5, 2019 23:09
@panchagnula panchagnula requested a review from yugangw-msft July 5, 2019 23:10
@panchagnula panchagnula added this to the Sprint 65 milestone Jul 5, 2019
@panchagnula
Copy link
Contributor Author

@yugangw-msft can you take a look at this & share feedback if any please? Want to make sure adding this validation is not breaking some CLI commandline guidelines.

…to identity commands to throw an error message if app is not part of RG

Style check fixes

Modifying help for appsettings

Resetting recording

Adding recording
Removing unused import
@panchagnula panchagnula force-pushed the sisirap-sprint65-fixes branch from e3c192c to 41bd822 Compare July 9, 2019 23:32
@yugangw-msft yugangw-msft merged commit 6be86c1 into Azure:dev Jul 10, 2019
@panchagnula panchagnula deleted the sisirap-sprint65-fixes branch July 10, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants