Upgrade to SDK rc6 #875
Upgrade to SDK rc6 #875
Conversation
|
|
| @@ -134,13 +134,11 @@ def body(self): | |||
| rg = s.resource_group | |||
| s.cmd('network public-ip create -g {} -n {} --dns-name {} --allocation-method static'.format(rg, s.public_ip_name, s.dns), checks=[ | |||
| JMESPathCheck('publicIp.provisioningState', 'Succeeded'), | |||
| JMESPathCheck('publicIp.publicIPAllocationMethod', 'Static'), | |||
| JMESPathCheck('publicIp.dnsSettings.domainNameLabel', s.dns) | |||
There was a problem hiding this comment.
JMESPathCheck('publicIp.dnsSettings.domainNameLabel', s.dns) [](start = 11, length = 61)
Are these no longer supported by the API?
There was a problem hiding this comment.
publicIp info is no longer returned.
There was a problem hiding this comment.
we should file a bug on this and comment out these lines for now
In reply to: 78789896 [](ancestors = 78789896)
| @@ -205,13 +199,13 @@ def body(self): | |||
| self.cmd('network express-route circuit list --resource-group {}'.format(self.resource_group), | |||
| checks=NoneCheck()) | |||
|
|
|||
| class NetworkExpressRouteCircuitScenarioTest(VCRTestBase): | |||
| class NetworkExpressRouteCircuitScenarioTest(ResourceGroupVCRTestBase): | |||
There was a problem hiding this comment.
ResourceGroupVCRTestBase [](start = 45, length = 24)
no need to convert this one yet since it doesn't actually use the resource group. This will help us track which tests need to be updated
There was a problem hiding this comment.
Since we use TODOs for tracking such changes, I added a TODO.
Our tests should move from VCRTestBase to ResourceGroupVCRTestBase and I think a TODO is a better way of tracking that changing it back to VCRTestBase.
-- No need to call .value on usage list operation any more -- max_retries and retry_wait no longer exist - In keyvault, family no longer exists in the constructor for Sku - Update dependencies for azure SDK rc6 - Re-record failing tests
-- No need to call .value on usage list operation any more
-- max_retries and retry_wait no longer exist
The following tests have been commented out as there is an issue for VMSS create #874: