webapps: Updating default node version used during creates #7821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update history will update with the next iteration |
panchagnula
force-pushed
the
sisirap-CLI-bugFixes-dev
branch
from
d464de7 to
f3254d0
Compare
| return poller | ||
| elif action == 'preview': | ||
| if target_slot is None: | ||
| result = client.web_apps.apply_slot_config_to_production(resource_group_name, | ||
| webapp, slot, True) | ||
| else: | ||
| result = client.web_apps.apply_slot_configuration_slot(resource_group_name, webapp, | ||
| slot, target_slot, True) | ||
| slot, (target_slot or 'production'), True) |
There was a problem hiding this comment.
we know target_slot is not None, so if should just be target_slot
yugangw-msft
approved these changes
Nov 13, 2018
yugangw-msft
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7749, #7689
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.