-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands/network dns #718
Commands/network dns #718
Conversation
BurtBiel
commented
Aug 19, 2016
•
edited
Loading
edited
0a311f5
to
025096b
Compare
Where are the remove commands? #Resolved |
cli_command('network dns record-set record add-ptr', add_dns_ptr_record) | ||
cli_command('network dns record-set record add-soa', add_dns_soa_record) | ||
cli_command('network dns record-set record add-srv', add_dns_srv_record) | ||
cli_command('network dns record-set record add-txt', add_dns_txt_record) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing the naming convention here: 'network dns record-set cname-record add'
Putting the record type first will enable quicker tab completion than if they are all appended with add-. Also, when you add the deletes, you won't get a very dense command set on "record" (which won't need to exist at all). If only 5 people have used these commands in Xplat, there's probably no harm in deviating from whatever scheme they used (which we already have anyways). #Resolved
Originally I was going to add them after the fact with other changes, but it turns out they are the only remaining changes, so I will include them soon In reply to: 241142095 [](ancestors = 241142095) |
c1cfa23
to
4410bb6
Compare
@tjprescott comments addressed #Closed |
e82e6f8
to
b17cede
Compare
b17cede
to
bac7eef
Compare
@tjprescott comments addressed In reply to: 241527754 [](ancestors = 241527754) |