Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands/network dns #718

Merged
merged 2 commits into from
Aug 22, 2016
Merged

Commands/network dns #718

merged 2 commits into from
Aug 22, 2016

Conversation

BurtBiel
Copy link
Contributor

@BurtBiel BurtBiel commented Aug 19, 2016

Command
    az network dns record-set create

Arguments
    --name -n           [Required]: The name of the RecordSet, relative to the name of the zone.
    --resource-group -g [Required]: Name of resource group.
    --type              [Required]: The type of DNS records in the record set.  Allowed values: A,
                                    AAAA, CNAME, MX, NS, PTR, SOA, SRV, TXT.
    --zone-name         [Required]: The name of the zone without a terminating dot.
    --ttl                         : Record set TTL (time-to-live).
Group
    az network dns record-set record

Commands:
    add-a
    add-aaaa
    add-cname
    add-mx
    add-ns
    add-ptr
    add-soa
    add-srv
    add-txt
Command
    az network dns record-set record add-soa

Arguments
    --email             [Required]: Email address.
    --expire-time       [Required]: Expire time (seconds).
    --host              [Required]: Domain name of the authoritative name server.
    --minimum-ttl       [Required]: Minimum TTL (time-to-live, seconds).
    --record-set-name   [Required]: The name of the RecordSet, relative to the name of the zone.
    --refresh-time      [Required]: Refresh value (seconds).
    --resource-group -g [Required]: Name of resource group.
    --retry-time        [Required]: Retry time (seconds).
    --serial-number     [Required]: Serial number.
    --zone-name         [Required]: The name of the zone without a terminating dot.
Command
    az network dns zone create

Arguments
    --name -n           [Required]: The name of the DNS zone to be created.  Must have at least 2
                                    segements, e.g. hostname.org.
    --resource-group -g [Required]: Name of resource group.
    --location -l                 : Location.  Default: global.
    --tags                        : Multiple semicolon separated tags in 'key[=value]' format.  Use
                                    "" to clear existing tags.

@tjprescott
Copy link
Member

tjprescott commented Aug 19, 2016

Where are the remove commands? #Resolved

cli_command('network dns record-set record add-ptr', add_dns_ptr_record)
cli_command('network dns record-set record add-soa', add_dns_soa_record)
cli_command('network dns record-set record add-srv', add_dns_srv_record)
cli_command('network dns record-set record add-txt', add_dns_txt_record)
Copy link
Member

@tjprescott tjprescott Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the naming convention here: 'network dns record-set cname-record add'
Putting the record type first will enable quicker tab completion than if they are all appended with add-. Also, when you add the deletes, you won't get a very dense command set on "record" (which won't need to exist at all). If only 5 people have used these commands in Xplat, there's probably no harm in deviating from whatever scheme they used (which we already have anyways). #Resolved

@BurtBiel
Copy link
Contributor Author

Originally I was going to add them after the fact with other changes, but it turns out they are the only remaining changes, so I will include them soon


In reply to: 241142095 [](ancestors = 241142095)

@BurtBiel BurtBiel force-pushed the commands/NetworkDNS branch 2 times, most recently from c1cfa23 to 4410bb6 Compare August 22, 2016 19:46
@BurtBiel
Copy link
Contributor Author

BurtBiel commented Aug 22, 2016

@tjprescott comments addressed #Closed

@BurtBiel BurtBiel force-pushed the commands/NetworkDNS branch 4 times, most recently from e82e6f8 to b17cede Compare August 22, 2016 20:57
@BurtBiel
Copy link
Contributor Author

@tjprescott comments addressed


In reply to: 241527754 [](ancestors = 241527754)

@tjprescott
Copy link
Member

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants