ignore files in vcs (eg, .git) direcotry #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehotinger
approved these changes
Aug 17, 2018
northtyphoon
force-pushed
the
bindu/fix-7084
branch
from
67e6d3e
to
26d7758
Compare
djyou
approved these changes
Aug 17, 2018
| @@ -401,11 +401,13 @@ def _pack_source_code(source_location, tar_file_path, docker_file_path): | |||
| def _ignore_check(tarinfo, parent_ignored, parent_matching_rule_index): | |||
| # ignore common vcs dir or file | |||
| if tarinfo.name in common_vcs_ignore_list: | |||
| logger.debug(".dockerignore: ignore vcs file '%s'", tarinfo.name) | |||
| logger.warning("Excluding '%s' based on default ignore rules", tarinfo.name) | |||
There was a problem hiding this comment.
Is this logging going to be overwhelming?
There was a problem hiding this comment.
It only logs top folder and file name.
|
@yugangw-msft / @tjprescott / @troydai PTAL and merge if it looks good. This is an important fix for customers. |
troydai
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7084
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.