-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore files in vcs (eg, .git) direcotry #7087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you'll have to update the version in the module to be 2.1.4 as well
67e6d3e
to
26d7758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -401,11 +401,13 @@ def _pack_source_code(source_location, tar_file_path, docker_file_path): | |||
def _ignore_check(tarinfo, parent_ignored, parent_matching_rule_index): | |||
# ignore common vcs dir or file | |||
if tarinfo.name in common_vcs_ignore_list: | |||
logger.debug(".dockerignore: ignore vcs file '%s'", tarinfo.name) | |||
logger.warning("Excluding '%s' based on default ignore rules", tarinfo.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this logging going to be overwhelming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only logs top folder and file name.
@yugangw-msft / @tjprescott / @troydai PTAL and merge if it looks good. This is an important fix for customers. |
Fix #7084
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.