[Monitor] Metric Alerts commands #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@troydai ping. |
troydai
approved these changes
Aug 16, 2018
| @@ -2,10 +2,99 @@ | |||
| # Copyright (c) Microsoft Corporation. All rights reserved. | |||
| # Licensed under the MIT License. See License.txt in the project root for license information. | |||
| # -------------------------------------------------------------------------------------------- | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
Ugr, what is this for? Was print used in this file?
There was a problem hiding this comment.
Mmmm...yeah. I can remove it.
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| import argparse | |||
|
|
|||
| import antlr4 | |||
There was a problem hiding this comment.
Was it brought in by the monitor module?
There was a problem hiding this comment.
Yes. This is needed for the grammar parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for near-realtime metric alerts. Deprecates and hides the old
monitor altermetric alert commands.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.