Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for properly loading extensions azdev verify load_all #6765

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Added check for properly loading extensions azdev verify load_all #6765

merged 3 commits into from
Jul 11, 2018

Conversation

williexu
Copy link
Contributor

Uses a new event to check failure of extensions being loaded.
Adds to CI check for extensions.

@williexu williexu requested a review from troydai July 11, 2018 01:00
tjprescott
tjprescott reviewed Jul 11, 2018
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that the command should probably be called azdev verify load-all for consistency.

@williexu
Copy link
Contributor Author

@tjprescott Done

@williexu williexu added this to the Sprint 41 milestone Jul 11, 2018
@williexu
load-all
9a1262a 
load-all
@williexu williexu merged commit 2020059 into Azure:dev Jul 11, 2018
@williexu williexu deleted the ext_load branch October 24, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 41
Development

Successfully merging this pull request may close these issues.
2 participants
@williexu @tjprescott