-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve profile support for azdev test
#6377
Conversation
View a preview at https://prompt.ws/r/Azure/azure-cli/6377 |
Codecov Report
@@ Coverage Diff @@
## dev #6377 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 133 133
Branches 9 9
===================================
Misses 133 133 Continue to review full report at Codecov.
|
ping @troydai |
@viananth you need to merge this to the |
Thank you @troydai @tjprescott. Merged. |
This PR:
Converts
--profile
from the format used in the CLI ("2017-03-09-profile") into the correct directory name ("2017_03_09_profile") so that tests can be run. Fixes Azdev test not honoring --profile parameter #6347.Maintains an index for each profile instead of a single index. Previously this would require you to run
azdev test
with--discover
or it would most likely use recordings from the wrong directory (the one that was used with the last --discover). If the index isn't found, the command will create it and automatically discover tests.Instead of checking the current CLI profile against
--profile
and issuing an error if they don't match, automatically set the profile based on--profile
and run accordingly.This checklist is used to make sure that common guidelines for a pull request are followed.
[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.