Improve profile support for azdev test
#6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
added
bug
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6377 |
Codecov Report
@@ Coverage Diff @@
## dev #6377 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 133 133
Branches 9 9
===================================
Misses 133 133Continue to review full report at Codecov.
|
|
ping @troydai |
troydai
approved these changes
May 22, 2018
|
@viananth you need to merge this to the |
|
Thank you @troydai @tjprescott. Merged. |
2 tasks
haroldrandom
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Converts
--profilefrom the format used in the CLI ("2017-03-09-profile") into the correct directory name ("2017_03_09_profile") so that tests can be run. Fixes Azdev test not honoring --profile parameter #6347.Maintains an index for each profile instead of a single index. Previously this would require you to run
azdev testwith--discoveror it would most likely use recordings from the wrong directory (the one that was used with the last --discover). If the index isn't found, the command will create it and automatically discover tests.Instead of checking the current CLI profile against
--profileand issuing an error if they don't match, automatically set the profile based on--profileand run accordingly.This checklist is used to make sure that common guidelines for a pull request are followed.
[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.