Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify package versions with last CLI release (as well as pyPI) #6066

Merged
merged 9 commits into from
Apr 10, 2018
Merged

Verify package versions with last CLI release (as well as pyPI) #6066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dede5c7
Use appropriate git revision range to prevent asking users to rebase
derekbekoe Apr 9, 2018
47f3fc2
Check version using last released tag as well
derekbekoe Apr 9, 2018
8eb919f
Change clone url
derekbekoe Apr 9, 2018
f632f02
Add TEST code change that should fail CI
derekbekoe Apr 9, 2018
dc86e17
Verified that it works
derekbekoe Apr 9, 2018
d8a3e34
test
derekbekoe Apr 9, 2018
dbdbf56
Use git diff instead
derekbekoe Apr 9, 2018
e7993d5
make change
derekbekoe Apr 9, 2018
1c20487
Fix revision now that we are using diff instead of log
derekbekoe Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use git diff instead
  • Loading branch information
@derekbekoe
derekbekoe committed Apr 9, 2018
commit dbdbf561ccd9058a1163a6c222ab5a967afe9804
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-advisor/azure/cli/command_modules/advisor/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
def load_arguments(self, _):
ids_arg_type = CLIArgumentType(nargs='+', options_list=['--ids'],
help='One or more resource IDs (space-delimited). If provided, no other '
'"hihi Resource Id" arguments should be specified.')
'"Resource Id" arguments should be specified.')

name_arg_type = CLIArgumentType(options_list=['--name', '-n'],
help='The name of the recommendation as output by the list command.',
Expand Down
2 changes: 1 addition & 1 deletion tools/automation/tests/verify_package_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def changes_require_version_bump(mod_name, mod_version, mod_path, base_repo=None
if revision_range:
# See https://github.com/travis-ci/travis-ci/issues/4596
revision_range = revision_range.replace('...', '..')
cmd = ["git", "log", "--pretty=format:* %s", revision_range, "--", mod_path, ":(exclude)*/tests/*"]
cmd = ["git", "diff", revision_range, "--", mod_path, ":(exclude)*/tests/*"]
changes = subprocess.check_output(cmd, cwd=mod_path, universal_newlines=True).strip()
if changes:
if is_available_on_pypi(mod_name, mod_version):
Expand Down